Skip to content

Conversation

@kjmeagher
Copy link
Member

Many of the datasets we were using were deleted from data/sim because
they were old and obsolete. So they were removed from from the list
of tested datasets. The CORSIKA dataset 23111 was added as the first
S-Frame CORSIKA dataset was added. L2 files for 23111 don't have
PolyplopiaPrimary so CorsikaWeighter was modified to just use
CorsikaWeightMap instead.

kjmeagher and others added 2 commits August 9, 2025 17:14
Many of the datasets we were using were deleted from data/sim because
they were old and obsolete. So they were removed from from the list
of tested datasets. The CORSIKA dataset 23111 was added as the first
S-Frame CORSIKA dataset was added. L2 files for 23111 don't have
PolyplopiaPrimary so CorsikaWeighter was modified to just use
CorsikaWeightMap instead.
@github-actions
Copy link

github-actions bot commented Aug 9, 2025

Test Results

    5 files  ±  0      5 suites  ±0   1m 17s ⏱️ -37s
  571 tests  -  65    359 ✅  -  52    212 💤  - 13  0 ❌ ±0 
2 855 runs   - 325  1 794 ✅  - 260  1 061 💤  - 65  0 ❌ ±0 

Results for commit c44e9ce. ± Comparison against base commit ffd7b5c.

This pull request removes 70 and adds 5 tests. Note that renamed tests count towards both.
tests.test_corsika_datasets ‑ test_dataset[h5py-12602]
tests.test_corsika_datasets ‑ test_dataset[h5py-20014]
tests.test_corsika_datasets ‑ test_dataset[h5py-20021]
tests.test_corsika_datasets ‑ test_dataset[pandas-12602]
tests.test_corsika_datasets ‑ test_dataset[pandas-20014]
tests.test_corsika_datasets ‑ test_dataset[pandas-20021]
tests.test_corsika_datasets ‑ test_dataset[pytables-12602]
tests.test_corsika_datasets ‑ test_dataset[pytables-20014]
tests.test_corsika_datasets ‑ test_dataset[pytables-20021]
tests.test_corsika_datasets ‑ test_dataset[uproot-12602]
…
tests.test_corsika_datasets ‑ test_dataset[h5py-023111]
tests.test_corsika_datasets ‑ test_dataset[pandas-023111]
tests.test_corsika_datasets ‑ test_dataset[pytables-023111]
tests.test_corsika_datasets ‑ test_dataset[uproot-023111]
tests.test_corsika_datasets ‑ test_dataset_i3file[023111]
This pull request removes 14 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
tests.test_corsika_datasets ‑ test_dataset_i3file[12602]
tests.test_corsika_datasets ‑ test_dataset_i3file[20014]
tests.test_corsika_datasets ‑ test_dataset_i3file[20021]
tests.test_nugen_datasets ‑ test_dataset_i3file[Level2_IC86.2011_nugen_NuE.010692.000000]
tests.test_nugen_datasets ‑ test_dataset_i3file[Level2_IC86.2011_nugen_NuMu.010634.000000]
tests.test_nugen_datasets ‑ test_dataset_i3file[Level2_IC86.2012_nugen_NuTau.011065.000001]
tests.test_nugen_datasets ‑ test_dataset_i3file[Level2_IC86.2012_nugen_nue.012646.000000.clsim-base-4.0.5.0.99_eff]
tests.test_nugen_datasets ‑ test_dataset_i3file[Level2_IC86.2012_nugen_numu.011374.000050.clsim-base-4.0.3.0.99_eff]
tests.test_nugen_datasets ‑ test_dataset_i3file[Level2_IC86.2012_nugen_nutau.011477.000000.clsim-base-4.0.3.0.99_eff]
tests.test_nugen_datasets ‑ test_dataset_i3file[Level2_IC86.2012_nugen_nutau.011836.000000.clsim-base-4.0.3.0.99_eff]
…
tests.test_corsika_datasets ‑ test_dataset_i3file[023111]

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@ffd7b5c). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #61   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        12           
  Lines           ?       841           
  Branches        ?         0           
========================================
  Hits            ?       841           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kjmeagher kjmeagher merged commit a1cb914 into main Aug 9, 2025
12 checks passed
@kjmeagher kjmeagher deleted the kjm/update_test_datasets branch August 9, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants