Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isse 360 faq section #367

Merged
merged 7 commits into from
Feb 29, 2024
Merged

isse 360 faq section #367

merged 7 commits into from
Feb 29, 2024

Conversation

aceppaluni
Copy link
Member

@aceppaluni aceppaluni commented Feb 29, 2024 •
edited by Idrinth
Loading

The Pull Request is ready

Website

  • mobile view is useable
  • desktop view is useable
  • no a-tags are used direktly (NavLink, MailLink, ExternalLink instead)
  • all new texts are added to the translation files (at least the english one)
  • tests have been added (if required)
  • shared code has been extracted in a different file

@aceppaluni aceppaluni marked this pull request as ready for review February 29, 2024 01:26
Idrinth
Idrinth requested changes Feb 29, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Idrinth Idrinth merged commit 8193682 into idrinth-api-bench:master Feb 29, 2024
22 checks passed
@aceppaluni aceppaluni deleted the a-contribution branch February 29, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Idrinth Idrinth Idrinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an FAQ to the bottom of the start page
2 participants
@aceppaluni @Idrinth