-
Notifications
You must be signed in to change notification settings - Fork 1
Bump com.github.ie3-institute:PowerSystemDataModel from 7.0.0 to 8.1.0 #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Bump com.github.ie3-institute:PowerSystemDataModel from 7.0.0 to 8.1.0 #599
Conversation
Bumps [com.github.ie3-institute:PowerSystemDataModel](https://github.com/ie3-institute/PowerSystemDatamodel) from 7.0.0 to 8.1.0. - [Release notes](https://github.com/ie3-institute/PowerSystemDatamodel/releases) - [Changelog](https://github.com/ie3-institute/PowerSystemDataModel/blob/dev/CHANGELOG.md) - [Commits](ie3-institute/PowerSystemDataModel@7.0.0...8.1.0) --- updated-dependencies: - dependency-name: com.github.ie3-institute:PowerSystemDataModel dependency-version: 8.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
f66134c to
34ba3f8
Compare
…e-PowerSystemDataModel-8.1.0
staudtMarius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some comments from my side.
src/main/scala/edu/ie3/osmogrid/guardian/run/SubGridHandling.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/osmogrid/guardian/run/SubGridHandlingSpec.scala
Outdated
Show resolved
Hide resolved
…e-PowerSystemDataModel-8.1.0
…e-PowerSystemDataModel-8.1.0
sebastian-peter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and comments from my side :)
src/test/scala/edu/ie3/osmogrid/guardian/run/SubGridHandlingSpec.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/osmogrid/guardian/run/SubGridHandling.scala
Outdated
Show resolved
Hide resolved
| "handle all received grid results" in new GridSupport { | ||
| val lvGrids: Seq[SubGridContainer] = Seq(mockSubGrid(1)) | ||
| val mvGrids: Seq[SubGridContainer] = Seq(mockSubGrid(3)) | ||
| val streetGraph: OsmGraph = new OsmGraph() | ||
|
|
||
| /* Result is forwarded to listener */ | ||
| // LV first | ||
| runningTestKit.run( | ||
| MessageAdapters.WrappedLvCoordinatorResponse( | ||
| RepLvGrids(lvGrids, streetGraph) | ||
| ) | ||
| ) | ||
|
|
||
| // MV | ||
| runningTestKit.run( | ||
| MessageAdapters.WrappedMvCoordinatorResponse( | ||
| RepMvGrids(mvGrids, None, Map.empty, assetInformation) | ||
| ) | ||
| ) | ||
|
|
||
| runningTestKit.run(HandleGridResults) | ||
| resultListener.expectMessageType[GridResult] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering how this worked before, and why now these additional messages are necessary. Maybe you have more insight?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats a very good question! I just remember that it broke and it looked like the GridResults were not there and thus couldn't be handled.
Co-authored-by: Sebastian Peter <[email protected]>
…e-PowerSystemDataModel-8.1.0
Bumps com.github.ie3-institute:PowerSystemDataModel from 7.0.0 to 8.1.0.
Release notes
Sourced from com.github.ie3-institute:PowerSystemDataModel's releases.
Changelog
Sourced from com.github.ie3-institute:PowerSystemDataModel's changelog.
Commits
21ed55dMerge pull request #1399 from ie3-institute/rel/df/#1398-release_8.1.04dcd202update citation cff90a7fd1update changelog690f348changelog4a1adb6Merge branch 'dev' into rel/df/#1398-release_8.1.0fd1758cMerge pull request #1358 from ie3-institute/df/#1357-validation-load835e05ffix test7da594afmt and docs085cad5Merge remote-tracking branch 'origin/df/#1357-validation-load' into df/#1357-...9095892refactor supported load profilesYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)