Skip to content

Fix equals behavior of ConnectorResult #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Fix equals behavior of ConnectorResult #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e65eb5c
Add metals to gitignore
t-ober Feb 2, 2024
d0b4289
Fix equals behavior of ConnectorResult
t-ober Feb 2, 2024
af8af43
Merge branch 'dev' into to/#1001-connector-eq
t-ober Feb 2, 2024
0ecaf2d
Update Changelog
t-ober Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,4 +242,9 @@ docs/readthedocs/_build
**/*.synctex.gz
**/*.synctex(busy)

docs/javadoc
### Metals ###
.metals/
.bloop/
project/**/metals.sbt

docs/javadoc
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed some tests no failing when they should [#958](https://github.com/ie3-institute/PowerSystemDataModel/issues/958)
- Fixed thermal-house-documentation [#873](https://github.com/ie3-institute/PowerSystemDataModel/issues/873)
- Fixed ElectricVehicle Documentation [#875](https://github.com/ie3-institute/PowerSystemDataModel/issues/875)
- Fixed Equal behavior of `ConnectorResult` [#1001](https://github.com/ie3-institute/PowerSystemDataModel/issues/1001)

### Changed
- Changing from comparing strings to comparing uuids in `EntitySource.findFirstEntityByUuid` [#829](https://github.com/ie3-institute/PowerSystemDataModel/issues/829)
Expand Down
1 change: 1 addition & 0 deletions src/main/java/edu/ie3/datamodel/models/result/connector/ConnectorResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ public void setiBAng(ComparableQuantity<Angle> iBAng) {
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
if (!super.equals(o)) return false;
ConnectorResult that = (ConnectorResult) o;
return iAMag.equals(that.iAMag)
&& iAAng.equals(that.iAAng)
Expand Down