Enhance LoadInput by categories (type,inhabitants,income) for markov #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoadInput.java LoadInputFactory.java
…tegories-for-markov' into pp/#1089-enhance-loadinput-by-categories-for-markov
|
@danielfeismann please look at "type". I'm not sure if I adjusted the tests correctly. |
danielfeismann
requested changes
Jun 3, 2024
src/main/java/edu/ie3/datamodel/io/factory/input/participant/LoadInputFactory.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/system/LoadInput.java
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/factory/input/participant/LoadInputFactoryTest.groovy
Show resolved
Hide resolved
…gories-for-markov # Conflicts: # CHANGELOG.md
Suggested change Co-authored-by: Daniel Feismann <[email protected]>
…tegories-for-markov' into pp/#1089-enhance-loadinput-by-categories-for-markov
|
I could not find a ComparableQuantity for inhabitants, and I have removed income as discussed. If you have any other ideas for inhabitants, please let me know. Otherwise, everything should be corrected. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1089