Skip to content

Conversation

@t-ober
Copy link
Contributor

@t-ober t-ober commented May 5, 2022

Resolves #585

@t-ober t-ober added the enhancement New feature or request label May 5, 2022
@t-ober t-ober marked this pull request as draft May 5, 2022 14:53
@sonarqubegithubprchecks

This comment has been minimized.

@t-ober t-ober marked this pull request as ready for review May 17, 2022 14:29
@t-ober t-ober requested a review from a team May 17, 2022 14:29
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks

This comment has been minimized.

@t-ober
Copy link
Contributor Author

t-ober commented May 18, 2022

!test

@sonarqubegithubprchecks

This comment has been minimized.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #591 (cc59554) into dev (37db9b0) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head cc59554 differs from pull request most recent head 1fa2437. Consider uploading reports for the commit 1fa2437 to get more accurate results

@@             Coverage Diff              @@
##                dev     #591      +/-   ##
============================================
+ Coverage     78.17%   78.27%   +0.09%     
- Complexity     2167     2202      +35     
============================================
  Files           280      284       +4     
  Lines          8499     8620     +121     
  Branches        801      805       +4     
============================================
+ Hits           6644     6747     +103     
- Misses         1464     1480      +16     
- Partials        391      393       +2     
Impacted Files Coverage Δ
...atamodel/models/input/system/type/HpTypeInput.java 75.00% <0.00%> (-6.25%) ⬇️
...java/edu/ie3/datamodel/io/factory/FactoryData.java 45.23% <0.00%> (-1.99%) ⬇️
...odel/io/source/csv/CsvSystemParticipantSource.java 86.61% <0.00%> (-0.24%) ⬇️
...model/io/processor/input/InputEntityProcessor.java 100.00% <0.00%> (ø)
...va/edu/ie3/datamodel/models/EmControlStrategy.java 100.00% <0.00%> (ø)
...java/edu/ie3/datamodel/models/ControlStrategy.java 72.72% <0.00%> (ø)
...edu/ie3/datamodel/models/input/system/EmInput.java 85.41% <0.00%> (ø)
...l/io/factory/input/participant/EmInputFactory.java 66.66% <0.00%> (ø)
...n/java/edu/ie3/datamodel/utils/ContainerUtils.java 81.25% <0.00%> (+0.04%) ⬆️
...java/edu/ie3/datamodel/io/processor/Processor.java 88.33% <0.00%> (+0.61%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc9433...1fa2437. Read the comment docs.

@sonarqubegithubprchecks

This comment has been minimized.

@t-ober
Copy link
Contributor Author

t-ober commented May 18, 2022

!test

@sonarqubegithubprchecks

This comment has been minimized.

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not forget an entry within the Changelog.

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks for your work here. Since this is important, I would feel better if someone also could do a review, therefore I just comment.

@sebastian-peter sebastian-peter self-requested a review May 20, 2022 11:03
@sonarqubegithubprchecks

This comment has been minimized.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

2 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell2 Code Smells

Coverage and Duplications

  • 60 percent coverage84.78% Coverage (77.30% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.60% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

# Conflicts:
#	src/main/java/edu/ie3/datamodel/io/processor/Processor.java
#	src/test/groovy/edu/ie3/test/common/SystemParticipantTestData.groovy
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks

# Conflicts:
#	src/main/java/edu/ie3/datamodel/io/processor/input/InputEntityProcessor.java
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebastian-peter sebastian-peter merged commit ad56b45 into dev Aug 3, 2022
@sebastian-peter sebastian-peter deleted the to/#585-ems-data-model branch August 3, 2022 12:02
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement the data model for an Energy Management System

4 participants