Skip to content

Improving column name validation #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jan 5, 2024
Merged

Improving column name validation #926

merged 29 commits into from
Jan 5, 2024

Conversation

@staudtMarius
Copy link
Member

@staudtMarius staudtMarius commented Nov 8, 2023 •
edited
Loading

Resolves #670
Resolves #839
Resolves #849

@staudtMarius staudtMarius self-assigned this Nov 8, 2023
@staudtMarius staudtMarius mentioned this pull request Nov 10, 2023
Closed
@staudtMarius staudtMarius marked this pull request as ready for review November 14, 2023 10:38
@staudtMarius staudtMarius mentioned this pull request Nov 14, 2023
Closed
sebastian-peter
sebastian-peter requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review took a bit longer than expected, because a lot of thoughts came up on my side. Let me know what you think, and whether I can assist.

staudtMarius and others added 3 commits November 24, 2023 10:46
@staudtMarius
Merge branch 'dev' into ms/#849-column-name-validation-should-only-ru…
f5319cb 
…n-once

# Conflicts:
#	CHANGELOG.md
#	src/main/java/edu/ie3/datamodel/io/connectors/CouchbaseConnector.java
#	src/test/groovy/edu/ie3/datamodel/io/factory/result/SystemParticipantResultFactoryTest.groovy
@staudtMarius
Implementing requested changes.
ad379c2
@staudtMarius
Merge branch 'dev' into ms/#849-column-name-validation-should-only-ru…
7ae0a77 
…n-once
@sebastian-peter sebastian-peter added this to the Version 4.2 milestone Nov 28, 2023
sebastian-peter
sebastian-peter requested changes Dec 1, 2023
View reviewed changes
@sebastian-peter sebastian-peter mentioned this pull request Dec 6, 2023
Closed
@sebastian-peter
Copy link
Member

Reminder about open question: Validation in TimeSeriesMetaInformationSource?

@sebastian-peter sebastian-peter mentioned this pull request Jan 5, 2024
Closed
@sebastian-peter sebastian-peter added io Issues relating to input/output code quality Code readability or structure is improved bug Something isn't working labels Jan 5, 2024
@sebastian-peter sebastian-peter merged commit 7584fbc into dev Jan 5, 2024
@sebastian-peter sebastian-peter deleted the ms/#849-column-name-validation-should-only-run-once branch January 5, 2024 13:46
@sebastian-peter sebastian-peter modified the milestones: Version 4.2, Version 5.0 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

Assignees

@staudtMarius staudtMarius

Labels

bug Something isn't working code quality Code readability or structure is improved io Issues relating to input/output

Projects

None yet

Milestone

Version 5.0

2 participants

@staudtMarius @sebastian-peter