JavaDoc cautionary hint for safeMapGet.
#933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-peter
requested changes
Nov 23, 2023
There was a problem hiding this comment.
Ok, upon inspection, I now understand the purpose of safeMapGet. It's only used in creating warning messages, where we do not want to fail if a value is missing (I guess this is also why you sometimes used getOrDefault as a replacement).
I now think it's best if we keep everything as it is, execpt placing a warning within JavaDoc above safeMapGet: It should only be used for building warning messages, and unintended results can be expected if used in other contexts.
…le-`EntitySource.safeMapGet` # Conflicts: # CHANGELOG.md
sebastian-peter
changed the title
safeMapGet.safeMapGet.
…le-`EntitySource.safeMapGet`
sebastian-peter
deleted the
ms/#828-throw-exception-instead-of-questionable-`EntitySource.safeMapGet`
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #828