Skip to content

Conversation

kkarthik11
Copy link
Contributor

updated zero divison error for Qualityutil boolean logic #295

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Please check out the sonarqube issue and see if you can solve it yourself.

Also, please look into adapting the JavaDoc of the method you adapted according to the changes you made (lines 130 - 142).

Copy link

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortened the documentation slightly. Thanks for the contribution!

@sebastian-peter sebastian-peter merged commit 5f1150d into main Oct 2, 2025
3 checks passed
@sebastian-peter sebastian-peter deleted the kk/#295-qualityutils-zero-values branch October 2, 2025 07:11
@sebastian-peter sebastian-peter linked an issue Oct 2, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuantityUtil#isEquivalentRel does not consider zero values
2 participants