Skip to content

Added external primary service worker #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Added external primary service worker #1546

wants to merge 9 commits into from

Conversation

@staudtMarius
Copy link
Member

Resolves #1545

@staudtMarius staudtMarius self-assigned this Sep 22, 2025
@staudtMarius staudtMarius added the enhancement New feature or request label Sep 22, 2025
@staudtMarius staudtMarius mentioned this pull request Sep 22, 2025
Closed
sebastian-peter
sebastian-peter reviewed Sep 23, 2025
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started my review and then realized that you didn't even ask for one yet. I apologize for that. But maybe my first comments are not for nothing... If they relate to parts that are not in their final form yet, please ignore them.

@staudtMarius
Copy link
Member Author

Thanks for your points. I will check them. I am currently increasing the test coverage to fix the sonarqube issue.

@danielfeismann danielfeismann added this to the Version 4.1 milestone Sep 24, 2025
sebastian-peter
sebastian-peter requested changes Sep 25, 2025
View reviewed changes
@staudtMarius
Merge branch 'dev' into ms/#1545-add-external-primary-service-worker
92975d5 
# Conflicts:
#	CHANGELOG.md
#	src/main/scala/edu/ie3/simona/sim/setup/ExtSimSetup.scala
@staudtMarius
Fixing issues after merging dev.
5a50773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastian-peter sebastian-peter Awaiting requested review from sebastian-peter

Requested changes must be addressed to merge this pull request.

Assignees

@staudtMarius staudtMarius

Labels

enhancement New feature or request

Projects

None yet

Milestone

Version 4.1

Development

Successfully merging this pull request may close these issues.

Add support for external primary data.

4 participants

@staudtMarius @sebastian-peter @danielfeismann