chore: Allow more GitHub-pages style domains #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added domains serve the GitHub pages equivalents of GitLab and Codeberg. As adjustments[1] to the i-d-template come in that facilitate more diverse hosting, users will want to diff draft versions from there. [1]: martinthomson/i-d-template#398
|
I'm unfamiliar with the definition of "semantic" or "conventional" that is used by the CI checker (for neither are terms defined for git); please suggest an acceptable commit title or point me to the relevant documentation. |
kesara
changed the title
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 11 11
Lines 965 965
=======================================
Hits 937 937
Misses 28 28 |
@chrysn You can find more about conventional commits here: https://www.conventionalcommits.org/en/ But it's all good since we squash and merge, we can change the final commit massage. |
kesara
approved these changes
Jul 19, 2023
kesara
added a commit
to ietf-tools/ietf-at-ui
that referenced
this pull request
Jul 19, 2023
Add new allowed domains from ietf-tools/author-tools#344
kesara
added a commit
to ietf-tools/ietf-at-ui
that referenced
this pull request
Jul 19, 2023
Add new allowed domains from ietf-tools/author-tools#344
chrysn
added a commit
to chrysn-pull-requests/ietf-at
that referenced
this pull request
Jul 19, 2023
The entry added in ietf-tools#344 was incorrectly using the plural TLD, when the actual TLD is singular ".page".
kesara
pushed a commit
that referenced
this pull request
Jul 19, 2023
The entry added in #344 was incorrectly using the plural TLD, when the actual TLD is singular ".page".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added domains serve the GitHub pages equivalents of GitLab and Codeberg. As adjustments1 to the i-d-template come in that facilitate more diverse hosting, users will want to diff draft versions from there.