Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tugas Secure Programming #7

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Tugas Secure Programming #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8396dbf
tambah laporan
trihas Dec 31, 2015
00fad08
Merge branch 'master' of https://github.com/trihas/WebGoat
trihas Dec 31, 2015
342afbd
Update AbstractLesson.java
trihas Dec 31, 2015
c497020
Update AbstractLesson.java
trihas Dec 31, 2015
ecfaafb
Update UserDatabase.java
trihas Dec 31, 2015
5b23c38
Update AbstractLesson.java
trihas Dec 31, 2015
d92ad55
Update HammerHead.java
trihas Dec 31, 2015
ce2433d
Update Screen.java
trihas Dec 31, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added laporan_23515009.docx
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion webgoat-container/src/main/java/org/owasp/webgoat/HammerHead.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public class HammerHead extends HttpServlet {
/**
* Description of the Field
*/
protected static SimpleDateFormat httpDateFormat;
private static SimpleDateFormat httpDateFormat;

/**
* Set the session timeout to be 2 days
Expand Down
14 changes: 8 additions & 6 deletions webgoat-container/src/main/java/org/owasp/webgoat/lessons/AbstractLesson.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,12 +724,14 @@ public boolean isAuthorized(WebSession s, String role, String functionId) {
logger.info("Checking if " + role + " authorized for: " + functionId);
boolean authorized = false;
try {
String query = "SELECT * FROM auth WHERE role = '" + role + "' and functionid = '" + functionId + "'";
try {
Statement answer_statement = WebSession.getConnection(s)
.createStatement(ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_READ_ONLY);
ResultSet answer_results = answer_statement.executeQuery(query);
authorized = answer_results.first();
String query = "SELECT * FROM auth WHERE role = ? and functionid = ?";
try {
PreparedStatement prepared_query = WebSession.getConnection(s)
.prepareStatement(query, ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_READ_ONLY);
prepared_query.setString(1, role);
prepared_query.setString(2, functionId);
ResultSet answer_results = prepared_query.executeQuery();
authorized = answer_results.first();
logger.info("authorized: " + authorized);
} catch (SQLException sqle) {
s.setMessage("Error authorizing");
Expand Down
2 changes: 1 addition & 1 deletion webgoat-container/src/main/java/org/owasp/webgoat/session/Screen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public abstract class Screen {
/**
* Description of the Field
*/
public static int MAIN_SIZE = 375;
public static final int MAIN_SIZE = 375;

// private Head head;
private Element content;
Expand Down
9 changes: 5 additions & 4 deletions webgoat-container/src/main/java/org/owasp/webgoat/session/UserDatabase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class UserDatabase {

private final String QUERY_ALL_USERS = "SELECT username FROM users;";
private final String QUERY_ALL_ROLES_FOR_USERNAME = "SELECT rolename FROM roles, user_roles, users WHERE roles.id = user_roles.role_id AND user_roles.user_id = users.id AND users.username = ?;";
private final String QUERY_TABLE_COUNT = "SELECT count(id) AS count FROM table;";
private final String QUERY_TABLE_COUNT = "SELECT count(id) AS count FROM ?;";

private final String DELETE_ALL_ROLES_FOR_USER = "DELETE FROM user_roles WHERE user_id IN (SELECT id FROM users WHERE username = ?);";
private final String DELETE_USER = "DELETE FROM users WHERE username = ?;";
Expand Down Expand Up @@ -86,13 +86,14 @@ public int getTableCount(String tableName) {
int count = 0;
try {
open();
Statement statement = userDB.createStatement();
ResultSet countResult = statement.executeQuery(QUERY_TABLE_COUNT.replace("table", tableName));
PreparedStatement prepared_tableName = userDB.prepareStatement(QUERY_TABLE_COUNT);
prepared_tableName.setString(1, tableName);
ResultSet countResult = prepared_tableName.executeQuery();
if (countResult.next()) {
count = countResult.getInt("count");
}
countResult.close();
statement.close();
prepared_tableName.close();
close();
} catch (SQLException e) {
e.printStackTrace();
Expand Down