Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#241 Showing battery time without battery icon (as an option) #245

Merged
merged 8 commits into from
Dec 27, 2020

Conversation

ftp27
Copy link

@ftp27 ftp27 commented Nov 7, 2020

Description

Related Issue

@D0miH
Copy link
Member

D0miH commented Dec 6, 2020

Sorry for taking so long to review your PRs. I was very busy the last few weeks.

The PR looks great, thanks so much for your contribution!
However, is there a specific reason that you used a NSView instead of a NSStackView for vertically stacking the selector and the 'Show battery icon'-checkbox?

I will review your other PRs too during the next few days.

@D0miH D0miH changed the base branch from master to development December 6, 2020 18:17
Copy link
Member

@D0miH D0miH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏻

@D0miH D0miH merged commit 388cdb1 into iglance:development Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants