Adventofcode #39
Merged
Adventofcode #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces performance timing in the Advent of Code 2024 day 01 puzzle solution and refactors the Advent of Code 2023 day 10 solution for better clarity and modern C++ practices.
- In 2024/day/01/historian_hysteria.cpp, high-resolution timing has been added for measuring execution time.
- In 2023/day/10/aoc_23_day_10_pipe_maze.cpp, the code has been refactored by replacing non-standard headers with explicit includes, updating function signatures, and using modern constructs such as std::unreachable() and structured binding.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| adventofcode/2024/day/01/historian_hysteria.cpp | Added timing code to measure execution time. |
| adventofcode/2023/day/10/aoc_23_day_10_pipe_maze.cpp | Refactored code for clarity with explicit headers and modern C++ constructs, and updated the solve function to return a value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.