-
-
Notifications
You must be signed in to change notification settings - Fork 206
Add make_hypercube()
#2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add make_hypercube()
#2417
Conversation
Co-authored-by: krlmlr <[email protected]>
make_hypercube()
krlmlr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot: Merge main and obey updated instructions.
krlmlr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot: Merge main and follow feedback and updated AGENTS.md .
R/make.R
Outdated
| #' print_all(make_hypercube(4)) | ||
| #' @cdocs igraph_hypercube | ||
| make_hypercube <- function(n, directed = FALSE) { | ||
| on.exit(.Call(R_igraph_finalizer)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| on.exit(.Call(R_igraph_finalizer)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the on.exit(.Call(R_igraph_finalizer)) line in cd7ad26. This is now handled by the autogenerated hypercube_impl() function, consistent with other recently added functions like make_circulant().
…rcube-function # Conflicts: # man/make_graph.Rd
Co-authored-by: krlmlr <[email protected]>
Merged main and updated the implementation to follow the new guidelines in AGENTS.md in commit cd7ad26:
All checks pass: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@schochastics: When good, please merge this. Rough workflow:
|
on.exit(.Call(R_igraph_finalizer))line (handled by_implfunction)r lifecycle::badge("experimental")@concept hypercubefor pkgdown reference indexhypercube_impl()Original prompt
make_hypercube()#1389✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.