Skip to content

add explicit derivatives of KL shell #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

rath3t
Copy link
Collaborator

@rath3t rath3t commented Jan 8, 2024

Closes #88.

@rath3t rath3t added the feature New feature label Jan 8, 2024
@rath3t rath3t added this to the v0.4 milestone Jan 8, 2024
@rath3t rath3t self-assigned this Jan 8, 2024
@rath3t
Copy link
Collaborator Author

rath3t commented Jan 8, 2024

@tarun-mitruka @henrij22 as an exercise can you give me a code Review. Suggest changes, more comments/doxygen comments or unclear implementations or other suggestions for refactoring.

You can wait till the CI worked

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8837c21) 82.53% compared to head (dc4ffaf) 92.87%.

❗ Current head dc4ffaf differs from pull request most recent head 0dfe755. Consider uploading reports for the commit 0dfe755 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #225       +/-   ##
===========================================
+ Coverage   82.53%   92.87%   +10.33%     
===========================================
  Files          48       49        +1     
  Lines        1867     2022      +155     
===========================================
+ Hits         1541     1878      +337     
+ Misses        326      144      -182     
Flag Coverage Δ
tests 92.87% <100.00%> (+10.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rath3t rath3t force-pushed the feature/hardcodedKLshellDerivatives branch 4 times, most recently from c1eced6 to 82af910 Compare January 8, 2024 12:12
Copy link
Collaborator

@tarun-mitruka tarun-mitruka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alex, thanks for the PR and giving for the PR review exercises. I added some comments. May be some can be incorporated in this PR and some can be moved to a new PR by opening a new issue.

Copy link
Collaborator

@henrij22 henrij22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for letting me review this PR.
I just found a few minor things, you could think about changing

@rath3t rath3t force-pushed the feature/hardcodedKLshellDerivatives branch 2 times, most recently from 1565365 to c44f040 Compare January 9, 2024 11:27
@rath3t rath3t enabled auto-merge (squash) January 9, 2024 15:55
@rath3t rath3t force-pushed the feature/hardcodedKLshellDerivatives branch 7 times, most recently from 9b08563 to 7d148de Compare January 10, 2024 13:17
@rath3t rath3t force-pushed the feature/hardcodedKLshellDerivatives branch from 7d148de to dc4ffaf Compare January 10, 2024 13:54
@rath3t rath3t force-pushed the feature/hardcodedKLshellDerivatives branch from dc4ffaf to 0dfe755 Compare January 10, 2024 14:32
@rath3t rath3t disabled auto-merge January 10, 2024 15:01
@rath3t rath3t merged commit c5e994f into main Jan 10, 2024
@rath3t rath3t deleted the feature/hardcodedKLshellDerivatives branch January 10, 2024 15:01
rath3t pushed a commit that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing non-linear KL shell
3 participants