-
Notifications
You must be signed in to change notification settings - Fork 3
[IN REVIEW] Refactor EAS to handle NonLinearElastic #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f72a67
to
5761ccd
Compare
0a215a0
to
81eae4d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 51.98% 52.33% +0.34%
==========================================
Files 84 86 +2
Lines 2697 2725 +28
==========================================
+ Hits 1402 1426 +24
- Misses 1295 1299 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3cbc683
to
572e568
Compare
b2c03d4
to
022022c
Compare
7437c55
to
ffa7248
Compare
This PR is converted to draft as it can only be fixed after #349 is merged. |
5444954
to
9962f11
Compare
800cc86
to
d9c6b54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
ikarus/finiteelements/mechanics/strainenhancements/linearandglstrains.hh
Outdated
Show resolved
Hide resolved
Hey @rath3t , apart from my comments above, I did the remaining changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check both of my comments and then merge this thing. Thanks!
0330f66
to
196c9da
Compare
196c9da
to
dbeee40
Compare
@rath3t and @henrij22 I am sorry I refactored everything again because the older implementation still disregarded the geometric stiffness contribution for |
dbeee40
to
f67853b
Compare
f45233f
to
1a34064
Compare
1a34064
to
b527409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention the interface change of EAS in the CHANGELOG?
@rath3t I am now merging this PR. If you have see (major) corrections to be done, of course let me know and I will incorporate it in a separate PR. Thanks both of you for all the comments and corrections until now. |
This PR focuses on refactoring
enhancedassumedstrains.hh
such that it is compatible also withnonlinearelastic.hh
.See
CHANGELOG.md
for more details.See also Issue #331.
DONE
updateState(/*...*/)
inmixin.hh
updateState()
function in nonlinear solvers. (see below the call byFEGenericObserver
as an example)updateState()
or does every element need to implement this - Every element has to implement as it can then also be used for instance to update history variables while working with plasticity.OTHER PR