[breaking] multiple refactorings in preparation for deferring torrent metadata resolution #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full context for what problem is being solved is here: #287
Some torrents don't resolve metadata from magnet links instantly and might take a long time.
The problem with this is that (lib)rqbit's current architecture implies that the torrents persisted in session have metadata fully resolved and always available.
So today the session has no idea of torrents that are "being resolved". The use-case is - we want to be able to add a torrent to a session, and let it resolve the metadata in background.
There are 2 conceptual ways to address that:
This PR prepares the code for the 2nd approach. Also some refactorings to increase maintainability of "add_torrent" and "start_torrent" code.