Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CompressibilityCoefficient quantity #506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CompressibilityCoefficient quantity #506

wants to merge 1 commit into from

Conversation

portyanikhin
Copy link
Contributor

@portyanikhin portyanikhin commented Feb 14, 2025 •
edited
Loading

Adds CompressibilityCoefficient quantity with base unit 1/Pa

@iliekturtles
Copy link
Owner

Changes look good.

https://en.wikipedia.org/wiki/Pressure_coefficient indicates that "pressure coefficient" is dimensionless. Can you provide a reference to 1/Pa being considered "pressure coefficient" or do you know of another quantity name?

@portyanikhin
Copy link
Contributor Author

portyanikhin commented Feb 17, 2025 •
edited
Loading

Yes, the current name (PressureCoefficient) is obviously unfortunate (I naively chose it by analogy with the TemperatureCoefficient).

It might be worth renaming it to CompressibilityCoefficient (according to: https://en.wikipedia.org/wiki/Compressibility). @iliekturtles, what do you think about this?

@portyanikhin portyanikhin force-pushed the add-pressure-coefficient branch from 13d1d57 to 49e63a0 Compare February 19, 2025 15:47
@portyanikhin portyanikhin changed the title Add PressureCoefficient quantity Add CompressibilityCoefficient quantity Feb 19, 2025
@portyanikhin
Copy link
Contributor Author

portyanikhin commented Feb 19, 2025 •
edited
Loading

Renamed it to CompressibilityCoefficient.

Unfortunately, I don't know how to safely rename the branch (most likely it will close this PR). If it's critical, I can close this PR and open a new one.

P.S. Something's wrong with CI, it doesn't seem to be related to my commits, but I'd like to draw your attention to it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@portyanikhin @iliekturtles