refactor: replace manual trait impls with derive_more#41
Merged
iljakuklic merged 11 commits intodevelfrom Apr 5, 2026
Merged
Conversation
Owner
iljakuklic
commented
Apr 4, 2026
iljakuklic
commented
- fixes Consider derive macro crates for trait implementations #26
Pulls in derive_more v2 and uses it to derive Display, Debug, AsRef, and From instead of writing them by hand, closing #26. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds derive_more::IsVariant to Phase, giving .is_meta() and .is_object() methods. Replaces seven == Phase::Meta/Object comparisons in the checker and staging with the new methods. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Name is a DST and is always used behind a reference, so the impl never enabled the HashMap lookup ergonomics it exists for. AsRef<str> covers the remaining conversion use cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add #[from] to Prim, Pi, Lam variants of Term for consistency with App, Let, Match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
iljakuklic
commented
Apr 4, 2026
Move Token enum and its associated constants (KEYWORDS, SYMBOLS) to a dedicated token.rs module. This improves code organization by separating token definitions from lexer implementation. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.