fix(hashrate): calculation based on network difficulty - #2
Open
IzioDev wants to merge 1 commit into
Open
Conversation
IzioDev
commented
Jun 26, 2025
| return hashrateData.networkHashesPerSecond; | ||
| const hashrateData = await kaspa.getBlockDagInfo({}); | ||
|
|
||
| const hashRate = hashrateData.difficulty * 2 * 10; |
Author
There was a problem hiding this comment.
maybe cast hashrateData.difficulty to BigInt before hand?
Author
There was a problem hiding this comment.
value I had: 909161465263109888n (closer to the explorer)
Owner
|
gm! sorry for the late reply. The solution checks out, but the result hashrate is bigger than javascript's maximum safe integer so the math could return inaccurate results, matter of fact it seems like the difficulty itself is already bigger than the maximum safe integer, so wasm should return it as a bigint in the first place, and then we can just multiply it by 20n. I'll check to see if perhaps it was already fixed in a newer WASM release, if not I'll raise and issue and once that's solved we can get this one working all solid 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.