Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH-DEBT] Change orientation field type in ExifEntity and ExifResponseDto #3022

Open
brighteyed opened this issue Jun 29, 2023 · 1 comment · May be fixed by #12792
Open

[TECH-DEBT] Change orientation field type in ExifEntity and ExifResponseDto #3022

brighteyed opened this issue Jun 29, 2023 · 1 comment · May be fixed by #12792
Assignees
@jrasm91
Labels
🗄️server tech-debt Technical debt 🖥️web

Comments

@brighteyed
Copy link
Contributor

Based on discussion in #3003.

  • Since exiftool-vendored disables the print conversion for the Orientation tag, I believe that guarantees we can get only 1-8 values for the orientation of photos.
  • ffprobe returns other values for the orientation (-90, 90, etc.)

We can change the type of the orientation field in ExifEntity and ExifResponseDto to enum to provide a better experience for all the clients.
@brighteyed brighteyed mentioned this issue Jun 29, 2023
Merged
@uhthomas
Copy link
Member

uhthomas commented Jun 30, 2023 •
edited
Loading

Be aware that #2908 will use exiftool for all media types and as such, the values will always be 1-8.

@jrasm91 jrasm91 self-assigned this May 13, 2024
@jrasm91 jrasm91 linked a pull request Sep 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrasm91 jrasm91

Labels
🗄️server tech-debt Technical debt 🖥️web
Projects
Immich Development
Status: 🚧 Tasks
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: orientation immich-app/immich
3 participants
@brighteyed @jrasm91 @uhthomas