fix(web): aspect ratio for photos with Rotate 270 CW orientation #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
uhthomas
reviewed
Jun 28, 2023
uhthomas
reviewed
Jun 28, 2023
|
Thank you for your thoughts @uhthomas and @jrasm91. Based on them, I pushed additional changes into this PR: I guess the use of the orientation tag should be pretty limited in our code. Now we use it only for the calculation of the justified layout. |
alextran1502
approved these changes
Jun 28, 2023
jrasm91
reviewed
Jun 28, 2023
This was referenced Jun 29, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We incorrectly determined the aspect ratio for the photos with
Rotate 270 CWorientation. This issue is mentioned in this discussion. This PR fixes it.