-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): missing svelte translations #10199
fix(web): missing svelte translations #10199
Conversation
I think this is a duplicate of #10161 in many aspects, correct? |
Unfortunatelly I haven't noticed that PR before :( I can wait untit #10161 is merged and then rebase my branch a add the rest of missing translations. Or @michelheusschen can add those to his branch. |
I should have added translations for everything user settings and admin related. If you exclude those from your PR there won't be any conflicts and you can proceed translating other areas. |
@waclaw66 the PR just got merged, so you can rebase now :) |
@waclaw66 We can potentially pull this into the upcoming hotfix if you get it rebased in the next couple of hours, if not no worries, ty for the PR 😄 |
I would like to get it done soon, unfortunatelly I got stucked on that failing test. Could you please to help me find out what is the problem? Thanks. |
The |
web/src/lib/components/shared-components/side-bar/more-information-albums.svelte
Outdated
Show resolved
Hide resolved
…tion-albums.svelte Co-authored-by: Michel Heusschen <[email protected]>
Co-authored-by: Michel Heusschen <[email protected]>
It should be done, ready to merge. |
Adds missing svelte translations.
Section page titles (e.g. Photos, Explore, Map) within .ts files are still untranslated.