Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): optional originalMimeType in asset response payload #10272

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

alextran1502
Copy link
Contributor

No description provided.

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to disable loading the original image if the shared link doesn't allow downloads.

@jrasm91
Copy link
Contributor

jrasm91 commented Jun 13, 2024

Ideally we should add some e2e tests to verify this "load original" logic, as this same issue seems to get reintroduced every few months. Specifically:

  • gif is a format that the original should load for
  • shared links should load the original gif.
  • shared links with downloads turned off should not load the original.

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice, ty.

@alextran1502 alextran1502 merged commit e2a2c86 into main Jun 13, 2024
22 checks passed
@alextran1502 alextran1502 deleted the fix/gif-play branch June 13, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants