refactor(web): byte unit utils #10332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
force-pushed
the
refactor/unit-conversion-web
branch
from
003b1fb to
3534ba4
Compare
mertalev
approved these changes
Jun 14, 2024
michelheusschen
approved these changes
Jun 14, 2024
web/src/lib/utils/byte-units.ts
Outdated
Comment on lines
22
to
24
| const magnitude = Math.floor(Math.log2(bytes === 0 ? 1 : bytes) / 10); | ||
|
|
||
| return [remainder, units[magnitude]]; | ||
| return [Number.parseFloat((bytes / 2 ** (magnitude * 10)).toFixed(maxPrecision)), magnitude]; |
There was a problem hiding this comment.
Maybe we can use base 1024 for these functions? But this isn't wrong at all.
Suggested change
| const magnitude = Math.floor(Math.log2(bytes === 0 ? 1 : bytes) / 10); | |
| return [remainder, units[magnitude]]; | |
| return [Number.parseFloat((bytes / 2 ** (magnitude * 10)).toFixed(maxPrecision)), magnitude]; | |
| const magnitude = Math.floor(Math.log(bytes === 0 ? 1 : bytes) / Math.log(1024)); | |
| return [Number.parseFloat((bytes / 1024 ** magnitude).toFixed(maxPrecision)), magnitude]; |
There was a problem hiding this comment.
Oh yeah we could, good idea!
jrasm91
approved these changes
Jun 14, 2024
danieldietzler
force-pushed
the
refactor/unit-conversion-web
branch
from
3534ba4 to
f3cf924
Compare
|
@danieldietzler Could this change affect #10927? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify byte utils using ✨ Math ✨