Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): include trashed assets in forced thumbnail generation #10389

Merged
merged 2 commits into from
Jun 16, 2024
Merged

fix(server): include trashed assets in forced thumbnail generation #10389

merged 2 commits into from
Jun 16, 2024

Conversation

michelheusschen
Copy link
Contributor

Fixes #10387

@alextran1502 alextran1502 merged commit 010eb1e into main Jun 16, 2024
22 checks passed
@alextran1502 alextran1502 deleted the fix/server-generate-thumbnails-include-trashed branch June 16, 2024 15:37
@mertalev
Copy link
Contributor

Are you sure this fixes #10387? The issue was about archived assets, not trashed assets.

@michelheusschen
Copy link
Contributor Author

Nope, somehow I thought the issue was about trashed assets. I'll open a new PR to include archived assets. Thank you for noticing!

@michelheusschen michelheusschen mentioned this pull request Jun 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

@alextran1502 alextran1502 alextran1502 approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generating all thumbnails do not generate thumbs of archived images
5 participants
@michelheusschen @mertalev @jrasm91 @alextran1502 @danieldietzler