-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): revamp places #12219
base: main
Are you sure you want to change the base?
feat(web): revamp places #12219
Conversation
Yeah exactly, this should be the number of places for the given country, but currently it says albums, as I havent figured out the translations, so I reused the one from the albums page :D |
Closing as no response to feedback, please feel free to re-open a new PR or comment on this one if you are planning to continue work on this in the future! 😄 |
👋 I am back from traveling and can pick up where I left off. Would you mind reopening the PR? |
2899b66
to
0c777aa
Compare
0c777aa
to
a664bd6
Compare
I rebased the PR and checked that there are no errors in the console. Can you take another look? I cant figure out how to fix the layout problem when no grouping is selected, but I am hoping one of you has an idea. |
Description
The
Places
page has been slightly revamped as follows:Open points/questions:
currently the country/group counter saysN Albums
instead ofN Places
, but I havent figured out the translations yetScreenshots
Default view
Grouped (looks a bit dumb on the demo server, as there is usually only 1 place per country)
Grouped and collapsed
Grouped and filtered
fixes #2631