Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mark people as favorite #14866

Merged
merged 12 commits into from
Feb 4, 2025
Merged

Conversation

arnolicious
Copy link
Contributor

Added the ability to mark people as favorite on web.

The GET /people Endpoint then sorts favorited people to the front of the list.
Thus the sorting would also apply in the app, however I have not (yet) added any indicators or functionality to mark people as favorite from there.

…he front of the people list
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks very good to me, thanks! Could you add a simple server unit test for it? :)

@arnolicious
Copy link
Contributor Author

I added a simple unit test for testing the toggling, I also tried adding a test to check the sorting behaviour, tho I have not ran it locally and it was mostly guessing that this could work :D @danieldietzler

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM

alextran1502 and others added 2 commits January 7, 2025 10:27
@github-actions github-actions bot added documentation Improvements or additions to documentation 📱mobile labels Jan 28, 2025
@arnolicious
Copy link
Contributor Author

arnolicious commented Jan 28, 2025

Alrighty, so I pulled in main, refactored (that one line lol) to kysely and also added the toggle Favorite functionality to the person detail page

The mobile and documentation labels got added because of the big merge, i don't think should be on this PR :D

@jrasm91 jrasm91 self-assigned this Jan 30, 2025
@jrasm91 jrasm91 force-pushed the feat/favorite-people branch from 23c66ef to df0b536 Compare February 4, 2025 08:26
@jrasm91 jrasm91 force-pushed the feat/favorite-people branch from df0b536 to 06f1566 Compare February 4, 2025 08:36
@jrasm91 jrasm91 enabled auto-merge (squash) February 4, 2025 08:49
@jrasm91 jrasm91 merged commit 7ec3610 into immich-app:main Feb 4, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants