Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): Server endpoint on the login screen. #16149

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

jpros
Copy link
Contributor

@jpros jpros commented Feb 17, 2025

Description

On the Immich iOS app, the server url upon logout is stored with the /api endpoint, which we no longer expose to / expect the user to set.

On the login screen, after logout, it added the "/api" suffix instead of using the default method getServerUrl, which takes care of sanitizing the URL.

Fixes #15951

How Has This Been Tested?

Logged in as regular, logged out, the Server URL now is without the API endpoint.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services)

…uffix instead of using the default method getServerUrl, which takes care of sanitizing the URL.
@jpros jpros changed the title Fixing the server endpoint on the login screen. fix(mobile) Server endpoint on the login screen. Feb 17, 2025
@jpros jpros changed the title fix(mobile) Server endpoint on the login screen. fix(mobile): Server endpoint on the login screen. Feb 17, 2025
@alextran1502
Copy link
Contributor

Hello, have you tried login/logout to different instances with different accounts?

@jpros
Copy link
Contributor Author

jpros commented Feb 17, 2025

@alextran1502 I tried with 2 different accounts on the same server, both went fine.

I used the same method that is currently being used by the menu screen.

Screenshot 2025-02-16 at 7 47 09 PM

@alextran1502 alextran1502 enabled auto-merge (squash) February 17, 2025 15:36
@alextran1502 alextran1502 merged commit efd8d8b into immich-app:main Feb 17, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS app stores login endpoint with /api on logout
2 participants