Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): search by partial asset path #16173

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

kvalev
Copy link
Contributor

@kvalev kvalev commented Feb 17, 2025

Description

Similarly to how one can search by partial filename, change the path search to work with partial matches instead of looking for a full match. This will enable third party plugins (as its not possible to search by path in the current UI) to search for all assets in a given folder.

How Has This Been Tested?

  • Querying the API without this PR for a partial folder name and getting 0 assets
  • Querying the API with this PR for a partial folder name and getting the expected number of assets

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services)

Similarly to how one can search by partial filename, change the
path search to work with partial matches instead of looking for a
full match.
@alextran1502
Copy link
Contributor

We don't have UI for this, correct?

@kvalev
Copy link
Contributor Author

kvalev commented Feb 18, 2025

We don't have UI for this, correct?

Correct

@alextran1502 alextran1502 merged commit 8634c59 into immich-app:main Feb 19, 2025
36 checks passed
@kvalev kvalev deleted the kvv-search-by-partial-path branch February 19, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants