Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mobile): lint #16182

Merged
merged 2 commits into from
Feb 18, 2025
Merged

chore(mobile): lint #16182

merged 2 commits into from
Feb 18, 2025

Conversation

shenlong-tanwen
Copy link
Member

Changes made

  • Updates the immich_lint package to resolve the current location after converting it to lower case.
  • Updates the DCM lint rules

@shenlong-tanwen shenlong-tanwen changed the title Chore/mobile lint chore(mobile): lint Feb 18, 2025
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. How is it that adding all these rules didn't require additional code changes?

@shenlong-tanwen
Copy link
Member Author

Looks good. How is it that adding all these rules didn't require additional code changes?

It does, it is just that we do not use DCM in our PR actions yet, so fix them slowly. There are several hundred issues reported by DCM and i'm planning to enforce it after fixing them. Will be handling them along with the current refactors

@alextran1502 alextran1502 merged commit 70d08a2 into main Feb 18, 2025
44 of 45 checks passed
@alextran1502 alextran1502 deleted the chore/mobile-lint branch February 18, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants