Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): enable exiftool largefilesupport #9894

Merged

Conversation

fvdnabee
Copy link
Contributor

Considering LFS in exiftool is only expected to be problematic on uncommon, older systems (ref), let's enable it by default. My previous PR introduced a system config, but in light of the previous finding I don't think a system config is necessary anymore.

@bo0tzz
Copy link
Member

bo0tzz commented May 30, 2024

For future reference, you can just force-push and edit a PR, you don't have to open a new one. It's fine now though of course 🙂

@aviv926
Copy link
Contributor

aviv926 commented May 30, 2024

Fix #4349

@mertalev mertalev merged commit afa10eb into immich-app:main May 30, 2024
22 of 23 checks passed
stephen304 added a commit to stephen304/immich that referenced this pull request Jun 11, 2024
alextran1502 pushed a commit that referenced this pull request Jun 12, 2024
…10167)

* Revert "feat(server): enable exiftool largefilesupport (#9894)"

This reverts commit afa10eb.

* feat(server): enable exiftool largefilesupport by passing options to read
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants