feat: decouple heading tag from size #108
Merged
+48
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-basten
force-pushed
the
fix/headings
branch
from
e0ee3f1 to
61f9c22
Compare
|
📖 Preview of ui.immich.app deployed to ui.pr-108.dev.immich.app |
ben-basten
force-pushed
the
fix/headings
branch
from
61f9c22 to
2c4ade8
Compare
jrasm91
reviewed
Feb 7, 2025
jrasm91
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating separate props for size vs. heading tag. Headings create semantic structure for navigating a page, which might not always correspond to the size. Also, allowing the use of a
<p>tag for generic headings.Breaking change: all headings need to specify a
tagprop to set heading level, andsizeis optional.