Skip to content

Conversation

@arnolicious
Copy link
Collaborator

@arnolicious arnolicious commented May 24, 2025

As mentioned over here: immich-app/immich#18570

This moves the "Popover Dropdown" component from the main project to the ui lib, and refactors it to use the Popover from bits-ui. This fixes some clipping/overflow issues when using the dropdown inside a modal (specifically the SlideshowSettingsModal)

Screenshots

image
image
image

@arnolicious arnolicious marked this pull request as ready for review May 24, 2025 18:16
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieldietzler danieldietzler requested a review from jrasm91 May 25, 2025 10:41
@danieldietzler
Copy link
Member

Screenshots in the PR description would be a nice addition, especially because we don't get a preview env :)

@danieldietzler danieldietzler requested review from jrasm91 and removed request for jrasm91 May 30, 2025 21:57
@arnolicious
Copy link
Collaborator Author

arnolicious commented Jun 7, 2025

I've now refactored the component to have a more aligned interface like the Select component, alongside with allowing for a custom trigger element to be passed in.

With that custom trigger, I could also now remove all the button props (color, shape, variant, size), should I?

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good!

Comment on lines +78 to +82
{#if !value}
{placeholder}
{:else}
{value?.label}
{/if}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably do this in JS land with {value?.label || placeholder}. That's definitely exclusively personal preference though

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah agreed, that's a remnant of what I had there before

@danieldietzler
Copy link
Member

I could also now remove all the button props (color, shape, variant, size), should I?

I don't think so. That's much more convenient if you only want to change a single thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants