Fix quickcheck-derived test case for refactor casts #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahomescu
force-pushed
the
ahomescu/restore_refactor
branch
from
e3fb41a to
c717e17
Compare
Contributor
|
Your branch needs a rebase (maybe once we land the base PR), then I'll take a look. |
ahomescu
force-pushed
the
ahomescu/restore_refactor
branch
4 times, most recently
from
a77dce1 to
51fbbcd
Compare
ahomescu
reviewed
Oct 9, 2025
fw-immunant
force-pushed
the
fw/refactor-casts-quickcheck
branch
2 times, most recently
from
7a89e71 to
882d68f
Compare
fw-immunant
changed the title
ahomescu
reviewed
Oct 28, 2025
ahomescu
approved these changes
Nov 22, 2025
this fixes the i32 -> u32 -> isize test case
fw-immunant
force-pushed
the
fw/refactor-casts-quickcheck
branch
from
4159922 to
251d5a2
Compare
Contributor
Author
|
I'd like to go ahead and merge this after CI, as this bug is the cause of occasional intermittent failures in CI (example). If we want to make the check less conservative again in the |
ahomescu
approved these changes
Nov 26, 2025
Contributor
|
I can't think of another way to simplify it, so LGTM, let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CI run randomly found this cast sequence that fails. I'm not sure what to do with it at this point, but this PR serves to at least document what's going on.