[ID-3851] fix: windows deeplink write location, warnings #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattb8
force-pushed
the
fix/windows-deeplink
branch
from
97ceb51 to
12c5494
Compare
ImmutableJeffrey
approved these changes
Jul 17, 2025
|
This is unfortunately not a fix, it is now broken in another way (testing this with any build an any install location should reveal that it now tries to run the executable as well from within persistentDataPath - i.e. the .cmd file is written with the wrong data) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the write location for Windows deeplink-related files when the game is installed into Program Files, avoiding the need for elevated permissions. Also fixes some compiler warnings.
ID-3851
Customer Impact
Fixed Windows deeplink file write location for installs in Program Files, and resolved compiler warnings.