feat: integrate credo in credentials api #2

mesaresachin · 2024-09-10T10:51:40Z

Integrate credo in Credentials and exchanges API

update all credential apis to consume methods from credo w3c credential service: issueCredential, verifyCredential, signPresentation, verifyPresentation
update the data model for verification result

jrhender

Thanks for the PR. Lots to talk about but it's a good starting effort.

apps/vc-api/src/vc-api/credentials/credentials.service.spec.ts

apps/vc-api/src/vc-api/credentials/credentials.service.ts

Signed-off-by: mesaresachin <[email protected]>

jrhender

Some additional comments

apps/vc-api/src/vc-api/credentials/credentials.service.ts

Needed for rush-pnpm patch-commit to work Signed-off-by: jrhender <[email protected]>

Ideally, a permanent upstream fix can be made in Credo. Signed-off-by: jrhender <[email protected]>

Signed-off-by: ShikharBhatt <[email protected]>

…tion - Fixed the test cases Signed-off-by: mesaresachin <[email protected]>

- remove spruce dependency - fix didAuth test case Signed-off-by: ShikharBhatt <[email protected]>

jrhender

I didn't have time yet to fully review, but I think we're definitely getting much closer 👍

apps/vc-api/src/vc-api/credentials/credentials.service.ts

apps/vc-api/src/vc-api/credentials/dtos/create-presentation.dto.ts

apps/vc-api/src/vc-api/credentials/credentials.service.ts

Signed-off-by: jrhender <[email protected]>

Signed-off-by: ShikharBhatt <[email protected]>

jrhender

A few more comments, but the PR is nearly there I think

apps/vc-api/src/vc-api/exchanges/types/exchange-verification-result.ts

apps/vc-api/src/vc-api/credentials/dtos/verify-options.dto.ts

apps/vc-api/src/vc-api/credentials/dtos/verify-credential.dto.ts

Signed-off-by: ShikharBhatt <[email protected]>

apps/vc-api/src/vc-api/credentials/credentials.service.ts

- revert options param in verify credential method - fix lint issue for any return type Signed-off-by: ShikharBhatt <[email protected]>

- fix lint issue for any return type Signed-off-by: ShikharBhatt <[email protected]>

jrhender

Looks good, thanks @ShikharBhatt and @mesaresachin

mesaresachin added the enhancement New feature or request label Sep 10, 2024

mesaresachin requested a review from jrhender September 10, 2024 10:51

mesaresachin self-assigned this Sep 10, 2024

jrhender reviewed Sep 11, 2024

View reviewed changes

apps/vc-api/src/vc-api/credentials/credentials.service.spec.ts Outdated Show resolved Hide resolved

apps/vc-api/src/vc-api/credentials/credentials.service.ts Outdated Show resolved Hide resolved

apps/vc-api/src/vc-api/credentials/credentials.service.ts Outdated Show resolved Hide resolved

ShikharBhatt force-pushed the credo-integration branch from b7f8808 to 34e64da Compare September 11, 2024 04:05

feat: Integrate credo in credentials api

121582c

Signed-off-by: mesaresachin <[email protected]>

mesaresachin force-pushed the credentials-api branch from 39249e7 to 121582c Compare September 11, 2024 05:22

chore: Restored presentationFrom method to use pex

ea0c22f

Signed-off-by: mesaresachin <[email protected]>

mesaresachin force-pushed the credentials-api branch from 0d828ee to ea0c22f Compare September 12, 2024 09:37

chore: Fixed test cases

961e809

Signed-off-by: mesaresachin <[email protected]>

jrhender reviewed Sep 16, 2024

View reviewed changes

apps/vc-api/src/vc-api/credentials/credentials.service.ts Outdated Show resolved Hide resolved

apps/vc-api/src/vc-api/credentials/credentials.service.ts Outdated Show resolved Hide resolved

jrhender and others added 5 commits September 17, 2024 14:52

chore: move pnpm config to separate file

57a2326

Needed for rush-pnpm patch-commit to work Signed-off-by: jrhender <[email protected]>

fix: temporary patch of credo for didAuth presentations

3905a7c

Ideally, a permanent upstream fix can be made in Credo. Signed-off-by: jrhender <[email protected]>

chore: e2e tests

d272c27

Signed-off-by: ShikharBhatt <[email protected]>

chore: Fixed verification result response for credential and presenta…

482c86d

…tion - Fixed the test cases Signed-off-by: mesaresachin <[email protected]>

chore: cleanup

1df4985

- remove spruce dependency - fix didAuth test case Signed-off-by: ShikharBhatt <[email protected]>

ShikharBhatt force-pushed the credentials-api branch from 90093d5 to 1df4985 Compare September 18, 2024 18:46

ShikharBhatt changed the title ~~Integrate credo in credentials api~~ feat: integrate credo in credentials api Sep 18, 2024

ShikharBhatt self-assigned this Sep 18, 2024

ShikharBhatt marked this pull request as ready for review September 18, 2024 18:50

jrhender reviewed Sep 19, 2024

View reviewed changes

jrhender and others added 2 commits September 19, 2024 18:02

feat(credentials.service): resuable transfromToCredoPresentation()

c70a602

Signed-off-by: jrhender <[email protected]>

fix: request changes for #2

ec00b2f

Signed-off-by: ShikharBhatt <[email protected]>

jrhender reviewed Sep 20, 2024

View reviewed changes

apps/vc-api/src/vc-api/exchanges/types/exchange-verification-result.ts Outdated Show resolved Hide resolved

apps/vc-api/src/vc-api/credentials/dtos/verify-options.dto.ts Show resolved Hide resolved

apps/vc-api/src/vc-api/credentials/dtos/verify-credential.dto.ts Show resolved Hide resolved

fix: rename the exchange verification result interface

94f5748

Signed-off-by: ShikharBhatt <[email protected]>

jrhender reviewed Sep 23, 2024

View reviewed changes

apps/vc-api/src/vc-api/credentials/credentials.service.ts Outdated Show resolved Hide resolved

ShikharBhatt added a commit that referenced this pull request Sep 23, 2024

fix: request changes for #2

57d4b98

- revert options param in verify credential method - fix lint issue for any return type Signed-off-by: ShikharBhatt <[email protected]>

fix: request changes for #2

d949d4f

- fix lint issue for any return type Signed-off-by: ShikharBhatt <[email protected]>

ShikharBhatt force-pushed the credentials-api branch from 57d4b98 to d949d4f Compare September 23, 2024 13:19

jrhender approved these changes Sep 24, 2024

View reviewed changes

jrhender merged commit 2235732 into credo-integration Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: integrate credo in credentials api #2

feat: integrate credo in credentials api #2

mesaresachin commented Sep 10, 2024 •

edited by ShikharBhatt

Loading

jrhender left a comment

jrhender left a comment

jrhender left a comment

jrhender left a comment

jrhender left a comment

feat: integrate credo in credentials api #2

feat: integrate credo in credentials api #2

Conversation

mesaresachin commented Sep 10, 2024 • edited by ShikharBhatt Loading

Integrate credo in Credentials and exchanges API

jrhender left a comment

Choose a reason for hiding this comment

jrhender left a comment

Choose a reason for hiding this comment

jrhender left a comment

Choose a reason for hiding this comment

jrhender left a comment

Choose a reason for hiding this comment

jrhender left a comment

Choose a reason for hiding this comment

mesaresachin commented Sep 10, 2024 •

edited by ShikharBhatt

Loading