Skip to content

Conversation

@coplat
Copy link
Contributor

@coplat coplat commented Jan 7, 2026

Description of change

Introduces end-to-end handling of nonces within the authorization flow. Previously, the API layer did not natively generate nonces. This update adds the logic to generate a secure nonce at the start of the flow and enforces validation of the returned nonce within the authorization response to prevent replay attacks.

Links to any relevant issues

How the change has been tested

Existing aggregate tests have been updated to include the nonce parameter. An additional test has been added to test instances where the wrong nonce is returned.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@coplat coplat self-assigned this Jan 7, 2026
@coplat coplat marked this pull request as ready for review January 7, 2026 10:45
@coplat coplat added the Blocked Something blocks the integration of this code. label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked Something blocks the integration of this code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants