helium/ui: add MRU tab cycling popup behind experimental flag#1376
Open
markwai wants to merge 1 commit intoimputnet:mainfrom
Open
helium/ui: add MRU tab cycling popup behind experimental flag#1376markwai wants to merge 1 commit intoimputnet:mainfrom
markwai wants to merge 1 commit intoimputnet:mainfrom
Conversation
|
Reviews (1): Last reviewed commit: "helium/ui: add MRU tab cycling popup beh..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
markwai
force-pushed
the
tab-cycling-popup
branch
from
2acbcef to
fa30b2c
Compare
|
@markwai thank you for opening this PR, this feature is really needed, IMO. i noticed that the CI is failing and there are two unresolved (?) issues from greptile. just wanted to ping you about this so this can ideally be implemented soon... |
markwai
force-pushed
the
tab-cycling-popup
branch
from
fa30b2c to
dc1e1a2
Compare
|
imho musthave |
markwai
force-pushed
the
tab-cycling-popup
branch
from
dc1e1a2 to
9accd99
Compare
|
excited about this feature! |
|
Pls resolve conflicts and let's merge |
markwai
force-pushed
the
tab-cycling-popup
branch
2 times, most recently
from
f97c4a6 to
049d3f4
Compare
Add a centered popup overlay for MRU tab cycling, gated behind the --helium-tab-cycling-popup chrome://flags entry (disabled by default). When the flag is enabled and Ctrl+Tab is pressed with MRU cycling active, a popup lists tabs in most-recently-used order. The highlight moves with each Tab press and activation is deferred until Ctrl is released. When the flag is disabled, tab cycling behaves as before with immediate activation on each step.
markwai
force-pushed
the
tab-cycling-popup
branch
from
049d3f4 to
5bf3647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your pull request to not get closed without review, please confirm that:
(an approved feature request, or confirmed bug).
otherwise I have marked my PR as draft.
organization if I lied by checking any of these checkboxes.
Tested on (check one or more):
Related to issue #238 (I put my changes behind a flag). Basically I've added a pop up when cycling MRU tabs. So the active tab does not switch until a selection is made from the popup (the keyboard shortcut is withheld). No mouse integration (mousover and click do not affect the popup). Currently I put this behind experiment flag #helium-tab-cycling-popup, ran tests and had to do some fixes to pass cirrus. Example of it working locally here:
tab-cycling-popup.mp4