helium/ui: add "Copy link" action to downloads context menu#1511
Draft
saberoueslati wants to merge 1 commit intoimputnet:mainfrom
Draft
helium/ui: add "Copy link" action to downloads context menu#1511saberoueslati wants to merge 1 commit intoimputnet:mainfrom
saberoueslati wants to merge 1 commit intoimputnet:mainfrom
Conversation
Author
|
I had also errors in the CI/CD piepline, I'll fix them then make it ready for review |
It is possible to have clear/clear from list option similar to firefox? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your pull request to not get closed without review, please confirm that:
(an approved feature request, or confirmed bug).
otherwise I have marked my PR as draft.
organization if I lied by checking any of these checkboxes.
Tested on (check one or more):
I tested my PR only on Linux at the moment, leaving this as a draft until I test on Windows, I'm building helium there at this moment
Video of manual test below :
Screencast.from.2026-04-29.00-09-03.webm
Closes #897
Adds a "Copy link" option to the download context menu that copies the original download source URL to the clipboard. Available on in-progress, paused, finished, and interrupted downloads.
Changes
COPY_DOWNLOAD_LINKcommand wired through all model/controller layersScopedClipboardWriterinDownloadUIModel::ExecuteCommanddownload_ui_context_menu.cckCopyDownloadLinkEnabled,kCopyDownloadLinkClicked)IDS_DOWNLOAD_MENU_COPY_LINKstring ("Copy link") ingenerated_resources.grd