Skip to content

helium/ui: add "Copy link" action to downloads context menu#1511

Draft
saberoueslati wants to merge 1 commit intoimputnet:mainfrom
saberoueslati:feat/copy-download-link
Draft

helium/ui: add "Copy link" action to downloads context menu#1511
saberoueslati wants to merge 1 commit intoimputnet:mainfrom
saberoueslati:feat/copy-download-link

Conversation

@saberoueslati
Copy link
Copy Markdown

For your pull request to not get closed without review, please confirm that:

  • An issue exists where the maintainers agreed that this should be implemented
    (an approved feature request, or confirmed bug).
  • I tested that my contribution works locally, and does not break anything,
    otherwise I have marked my PR as draft.
  • If my contribution is non-trivial, I did not use AI to write most of it.
  • I understand that I will be permanently banned from interacting with this
    organization if I lied by checking any of these checkboxes.

Tested on (check one or more):

  • Windows
  • macOS
  • Linux

I tested my PR only on Linux at the moment, leaving this as a draft until I test on Windows, I'm building helium there at this moment

Video of manual test below :

Screencast.from.2026-04-29.00-09-03.webm

Closes #897

Adds a "Copy link" option to the download context menu that copies the original download source URL to the clipboard. Available on in-progress, paused, finished, and interrupted downloads.

Changes

  • New COPY_DOWNLOAD_LINK command wired through all model/controller layers
  • Clipboard write implemented via ScopedClipboardWriter in DownloadUIModel::ExecuteCommand
  • Menu item added to all four context menu states in download_ui_context_menu.cc
  • Stats tracking added (kCopyDownloadLinkEnabled, kCopyDownloadLinkClicked)
  • New IDS_DOWNLOAD_MENU_COPY_LINK string ("Copy link") in generated_resources.grd

@saberoueslati
Copy link
Copy Markdown
Author

I had also errors in the CI/CD piepline, I'll fix them then make it ready for review

@nsk-47
Copy link
Copy Markdown

nsk-47 commented Apr 29, 2026

I had also errors in the CI/CD piepline, I'll fix them then make it ready for review

It is possible to have clear/clear from list option similar to firefox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR]: "Copy Download Link" context menu action in downloads bubble

2 participants