helium/ui/layout: remove margin after pinned in vertical layout#1513
Open
Jasdeep-Dhillon wants to merge 1 commit intoimputnet:mainfrom
Open
helium/ui/layout: remove margin after pinned in vertical layout#1513Jasdeep-Dhillon wants to merge 1 commit intoimputnet:mainfrom
Jasdeep-Dhillon wants to merge 1 commit intoimputnet:mainfrom
Conversation
|
Reviews (1): Last reviewed commit: "helium/ui/layout: remove margin after pi..." | Re-trigger Greptile |
15c316e to
59a14af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your pull request to not get closed without review, please confirm that:
(an approved feature request, or confirmed bug).
otherwise I have marked my PR as draft.
organization if I lied by checking any of these checkboxes.
Tested on (check one or more):
Related to issue #1498 which mentioned to remove the extra margin after pinned tabs when using vertical layout. I have removed the check which used collapsed state to show the separator which resulted in extra margin after pinned tab.
Before:

After:
