feat(mission): evidence chips on Done cards — test tallies, tsc & PR links (#425)#437
Merged
Conversation
…inks (#425) A finished card now carries proof of what happened without opening the session: deterministic regex extraction over the same bounded output tail the headline reads — no LLM pass. Chips cover vitest/jest/pytest/ unittest tallies (last occurrence per runner wins, so a red run re-run green reports green), tsc error counts, and up to two PR links. - server.py: _mc_evidence_from_log + evidence field on queue/drawer cards (always present; empty for live cards and chats). The tail is now read once per card and shared with the headline. - web: EvidenceChips component on board card + drawer, chip styles - mobile: chips on the MissionControlScreen card row - shoot-mission fixtures: retired the leftover 'review' states from #435 and added evidence to the mocked cards Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Evidence chips on Mission Control's Done cards (#425): a finished card now carries proof of what happened — test tallies, tsc errors, and PR links — so review starts from evidence without opening the session. This re-homes the "evidence chips" idea from the original proposal onto Done, after #435 folded the "Needs review" column away.
Extraction is fully deterministic — regex over the same bounded ANSI-stripped output tail the headline already reads; no LLM pass (by design). Covered signals:
Ran N tests+OK/FAILED(failures=…)). Last occurrence per runner wins, so a red run that was re-run green reports green.error TSxxxx:count) — failure-only, since a clean tsc is silent.github.com/…/pull/N), deduped, capped at 2, rendered as neutral link chips.The tail is now read once per card and shared between headline + evidence. Chips ride the queue and drawer payloads (
evidenceis always present; empty for live cards and chats), and render on the web board card, the detail drawer, and the mobile card row. Also retired the leftoverreviewstates from theshoot-mission*screenshot fixtures.Testing
server.pysuite — 1271 passed (6 new: chip extraction ok/fail/last-tally-wins, unittest FAILED parsing, empty evidence on live cards & chats)tsc+ vite build + vitest — 450 passed (new chip-rendering test)tsc --noEmit+ vitest — 40 passedbash -n start.sh— unchanged surfaces, greenscripts/shoot-mission.mjsagainst the real SPA🤖 Generated with Claude Code