add AttachmentsMixin #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlinsj
reviewed
Aug 5, 2020
attachments/__init__.py
Outdated
| from attachments.mixins import AttachmentsMixin | ||
| return AttachmentsMixin | ||
|
|
||
| AttachmentsMixin = get_AttachmentsMixin() |
There was a problem hiding this comment.
do we need to have this in attachments.init?
There was a problem hiding this comment.
also version_info need to be bumped to 3.2.5 or an equivalent increment to the latest attachment version in the 3.0 branch)
tomlinsj
reviewed
Aug 13, 2020
attachments/__init__.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| __version_info__ = (3, 3, 0) | |||
| __version_info__ = (3, 3, 1) | |||
There was a problem hiding this comment.
this is a feature not a hotfix, so it should be 3.4.0
added 4 commits
August 13, 2020 10:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.