Feature: Add a WarningPanel as an alternative to the EntityIncidentCard #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is the pattern used in other wraning panel for backstage eg. https://github.com/backstage/backstage/blob/478736db14a1877e9dc92a31c26cecc90c121568/plugins/catalog/src/components/EntityRelationWarning/EntityRelationWarning.tsx
we should not impact users with those errors, for instance when entity is not type is not supported Signed-off-by: Alexandre Couedelo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ideally wanted to know when landing on an entity page if it was affected by an incident. However, we found that the
EntityIncidentCardwas taking up too much space. Instead, we think aWarningPanelwould be a much better way to inform users of Ongoing incidents.Other changes:
yarn startand see what the different components of the plugin look like.