-
Notifications
You must be signed in to change notification settings - Fork 0
Add Authentication (Auth.js) #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
brandonw504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far!
Split the code up into (somewhat) more reasonable parts.
|
There seems to be some issues with throwing errors in the Taking a look at the documentation, the error code does get sent to the URL which is intended behaviour. However, at the bottom it states that "The full error is always logged on the server, if you need to debug." I have yet to find a way to disable that. |
57e1cd0 to
c923b81
Compare
Additionally, there is now functionality for the Log In and Sign Up pages as well.
This commit adds API protection via an API key. This fixes issue #68 on GitHub.
|
As of the latest commit, I have not actually tested the API key, I'm unsure how to make requests directly to NextJS. |
brandonw504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to go! We can address some of the TODOs you marked in the future since there's more important things to do for now.
This fixes #52 and #68. It is a work-in-progress PR so it is not yet fully complete.