Skip to content

Conversation

@beanbeanjuice
Copy link
Contributor

@beanbeanjuice beanbeanjuice commented Feb 10, 2025

This fixes #52 and #68. It is a work-in-progress PR so it is not yet fully complete.

@beanbeanjuice beanbeanjuice linked an issue Feb 10, 2025 that may be closed by this pull request
5 tasks
Copy link
Contributor

@brandonw504 brandonw504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far!

Split the code up into (somewhat) more reasonable parts.
@beanbeanjuice
Copy link
Contributor Author

There seems to be some issues with throwing errors in the authorize() function. It spits out errors into the server console, which seems to be an intended effect? Even creating a production build, these errors seem to output anyway.

Taking a look at the documentation, the error code does get sent to the URL which is intended behaviour. However, at the bottom it states that "The full error is always logged on the server, if you need to debug."

I have yet to find a way to disable that.

Additionally, there is now functionality for the Log In and Sign Up
pages as well.
@beanbeanjuice beanbeanjuice linked an issue May 2, 2025 that may be closed by this pull request
This commit adds API protection via an API key. This fixes issue #68 on
GitHub.
@beanbeanjuice
Copy link
Contributor Author

As of the latest commit, I have not actually tested the API key, I'm unsure how to make requests directly to NextJS.

Copy link
Contributor

@brandonw504 brandonw504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to go! We can address some of the TODOs you marked in the future since there's more important things to do for now.

@brandonw504 brandonw504 merged commit 49571bd into main May 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API Protection Authentication: Auth.js

6 participants