Skip to content

Conversation

@palina0k
Copy link

Initial commit for PR on Cloudinary

Copy link
Contributor

@brandonw504 brandonw504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the contexts like AuthContext and SidebarContext aren't actually part of uploading media (we're using Auth.js instead of the custom authentication system in the CMS). Also, can you implement these components in a page? You'll probably see that a lot of things won't work if you just directly take from the CMS. Sorry I forgot to mention this specifically earlier, but all we want right now is the ability to upload a file and associate it with a particular product. The media gallery is relatively low priority at the moment since most people probably won't be using duplicate images for different products.

…ia folder under (api)/_typedefs and (api)/_datalib with the appropriate mediaItem and findMediaItem that are called in (pages)/uploaded-media/page.tsx
Copy link
Contributor

@brandonw504 brandonw504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice you changed the import statements for some of the components in the uploaded-media page.tsx, but they're still not directing to the correct path. Just in case I didn't explain this very well before, the @ symbol before the path name refers to a shortcut that we specify in the tsconfig. It isn't working since componentmedia isn't a shortcut. Also, even though you don't have the actual upload functions yet, can you test the UI and get it into a state where instead of calling the upload function, it can maybe just display a popup saying that the file was uploaded (or anything temporary)? We're less concerned about getting this actually working than being able to see whether the UI and drag and drop/file system popup behavior looks correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants