Skip to content

Conversation

@VinBid
Copy link
Contributor

@VinBid VinBid commented Mar 3, 2025

  • Created cloudinary implementation
  • Needs more testing before pushing to prod

Copy link
Contributor

@brandonw504 brandonw504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing your changes so far. Can you fix the linting errors to make sure it passes the development check? Also, I noticed you're using some utils like parseAndReplace or mongoClient that were in the CMS, but they're meant for use in MongoDB, and not for Postgres. Can you make sure everything is designed for the database we're using?

Copy link
Contributor

@brandonw504 brandonw504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the CRUD operations for Media items don't seem correct, can you take a look at, for example, the User object, to see how the API should be structured? I also see that there's still some files leftover like mongoClient.mjs and the auth folder inside _types. Can you modify the CRUD operations for Media to match the other examples in the API?

Copy link
Contributor

@brandonw504 brandonw504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the API, you'll need to make the typedefs and resolvers in addition to the services, and also create the data model in our database. Make sure to test it on the GraphQL playground!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants