-
Notifications
You must be signed in to change notification settings - Fork 0
Feat add media object Working PR #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
VinBid
commented
Mar 3, 2025
- Created cloudinary implementation
- Needs more testing before pushing to prod
* Not confident in my typescript types.
brandonw504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing your changes so far. Can you fix the linting errors to make sure it passes the development check? Also, I noticed you're using some utils like parseAndReplace or mongoClient that were in the CMS, but they're meant for use in MongoDB, and not for Postgres. Can you make sure everything is designed for the database we're using?
brandonw504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the CRUD operations for Media items don't seem correct, can you take a look at, for example, the User object, to see how the API should be structured? I also see that there's still some files leftover like mongoClient.mjs and the auth folder inside _types. Can you modify the CRUD operations for Media to match the other examples in the API?
brandonw504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the API, you'll need to make the typedefs and resolvers in addition to the services, and also create the data model in our database. Make sure to test it on the GraphQL playground!