-
Notifications
You must be signed in to change notification settings - Fork 0
Create Product Listing - Page #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ll working on rendering each sub-page.
…ng correct design.
|
Do you think you can extract your components into different files? The different tabs can be different files, and it would be nice to have the forms be almost like assembling lego blocks together. If you need a short text input, you can just add (you can see an example from the Hackdavis Hub: https://github.com/HackDavis/hackdavis-hub/tree/main/app/(pages)/admin/_components/ShortInput). If you need a rich text editor for the description, you can use (this is actually built out here: https://github.com/include-davis/Include-Estore-Manager/tree/main/app/(pages)/_components/Textbox). This way, your form can just look something like this on here: https://github.com/HackDavis/hackdavis-hub/blob/main/app/(pages)/admin/_components/Announcements/AnnouncementForm.tsx. It's sort of like a generalized form builder that can be used to create many different types of forms easily. For now, you don't have to worry about making a component for file uploading, Austin will work on that and add it in. Just maybe something for the short inputs and the textbox (description). |
…its own file; incorporated the existing Textbox component; still working on the accurate design/format as well as how the listing will be saved/stored.
brandonw504
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually it looks great so far! I notice you added ShortInput but you haven't gotten to using it in the components so far. If you have any questions about how to incorporate it into the pages, just let me know! Also, please take another look at the designs! Sorry they've been changing, I just had a few things I asked our designer for.
Some initial changes to Product Form to become 'Create Product Listing' page.