Skip to content

Conversation

@palina0k
Copy link

@palina0k palina0k commented Apr 8, 2025

Some initial changes to Product Form to become 'Create Product Listing' page.

@palina0k palina0k changed the title Initial Commit to Create Product Listing Page Create Product Listing - Page Apr 8, 2025
@brandonw504
Copy link
Contributor

Do you think you can extract your components into different files? The different tabs can be different files, and it would be nice to have the forms be almost like assembling lego blocks together. If you need a short text input, you can just add (you can see an example from the Hackdavis Hub: https://github.com/HackDavis/hackdavis-hub/tree/main/app/(pages)/admin/_components/ShortInput). If you need a rich text editor for the description, you can use (this is actually built out here: https://github.com/include-davis/Include-Estore-Manager/tree/main/app/(pages)/_components/Textbox). This way, your form can just look something like this on here: https://github.com/HackDavis/hackdavis-hub/blob/main/app/(pages)/admin/_components/Announcements/AnnouncementForm.tsx. It's sort of like a generalized form builder that can be used to create many different types of forms easily. For now, you don't have to worry about making a component for file uploading, Austin will work on that and add it in. Just maybe something for the short inputs and the textbox (description).

palina0k and others added 2 commits May 22, 2025 22:10
…its own file; incorporated the existing Textbox component; still working on the accurate design/format as well as how the listing will be saved/stored.
Copy link
Contributor

@brandonw504 brandonw504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually it looks great so far! I notice you added ShortInput but you haven't gotten to using it in the components so far. If you have any questions about how to incorporate it into the pages, just let me know! Also, please take another look at the designs! Sorry they've been changing, I just had a few things I asked our designer for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants