Header #51
Merged
Header #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
naomitzhao
requested changes
Mar 17, 2025
Collaborator
naomitzhao
left a comment
naomitzhao
left a comment
There was a problem hiding this comment.
Hi Jon, this looks really good! It's almost ready to merge just how it is. I just pointed out a few small fixes/bugs I noticed-- shouldn't take too long. Let me know when you're done implementing the changes I requested and we'll go ahead and merge this PR. And if you have any questions just reach out for clarification/help. Great work!! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mobile header - no dropdown onclick animation, tweaked mixins for tablet a little bit